Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for brand Get/Update/Delete #87

Merged
merged 4 commits into from
Mar 19, 2019
Merged

Add support for brand Get/Update/Delete #87

merged 4 commits into from
Mar 19, 2019

Conversation

nukosuke
Copy link
Owner

@nukosuke nukosuke commented Mar 19, 2019 •
edited
Loading

Close #61

  • Impl get/update/delete
  • test
  • Regenerate mock client

@nukosuke nukosuke added this to the v0.2.0 milestone Mar 19, 2019
@nukosuke nukosuke added the API Support New API support label Mar 19, 2019
@nukosuke nukosuke self-assigned this Mar 19, 2019
@nukosuke nukosuke marked this pull request as ready for review March 19, 2019 14:40
@nukosuke nukosuke requested a review from tamccall March 19, 2019 14:40
tamccall
tamccall approved these changes Mar 19, 2019
View reviewed changes
Copy link
Contributor

@tamccall tamccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nukosuke nukosuke merged commit 80272ce into master Mar 19, 2019
@nukosuke nukosuke deleted the brand-rud branch March 19, 2019 15:12
fairyhunter13 added a commit to fairyhunter13/go-zendesk that referenced this pull request Jul 12, 2020
@fairyhunter13
Merge pull request nukosuke#87 from nukosuke/brand-rud
7ade467 
Add support for brand Get/Update/Delete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamccall tamccall tamccall approved these changes

Assignees

@nukosuke nukosuke

Labels
API Support New API support
Projects
None yet
Milestone
v0.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nukosuke @tamccall