Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated to GitHub Actions #112

Merged
merged 7 commits into from
Apr 3, 2022
Merged

Conversation

overheadhunter
Copy link
Contributor

@overheadhunter overheadhunter commented Oct 6, 2021

This fixes #74 by adding a workflow file resembling the old travis configuration.

Note that I had to upgrade Gradle and replace cobertura by jacoco as well.

The new Java 17 build is failing due to missing Nashorn engine required in JavaPortTest.java and ApproachComparisonTest.java. Fixing this is out of scope of this issue, though.

Edit: I tried using a GitHub Action provided by Coveralls, but apparently it only digests the lcov format, so I gave it up again. In order for Coveralls to work, you need to create a GitHub Secret named COVERALLS_REPO_TOKEN for this repo.

@vvatanabe
Copy link
Member

@overheadhunter Thanks! I will chk it ASAP ;D

build.gradle Outdated Show resolved Hide resolved
@vvatanabe
Copy link
Member

@overheadhunter LGTM! I've asked the GitHub admin in Nulab Inc to add the secret (COVERALLS_REPO_TOKEN). I will merge the secret when it is added.

@vvatanabe vvatanabe merged commit 6392d89 into nulab:master Apr 3, 2022
@vvatanabe
Copy link
Member

@overheadhunter Sorry for the late reply. We have successfully migrated to GitHub Action. Thanks!

@overheadhunter overheadhunter deleted the gh-actions branch April 3, 2022 06:37
@overheadhunter
Copy link
Contributor Author

@vvatanabe better late than never. 😉 I updated #104 already, hope this can be resolved soon, too! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate GitHub Action
2 participants