Make Scoring.factorial(int) return long #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#109 should be close if merge this |
vvatanabe
reviewed
Apr 3, 2022
| @@ -12,6 +12,8 @@ | |||
|
|
|||
| public static final int MIN_GUESSES_BEFORE_GROWING_SEQUENCE = 10000; | |||
|
|
|||
| public static final long JS_NUMBER_MAX = 9007199254740992L; | |||
There was a problem hiding this comment.
@InkerBot Sorry for the late reply. JS_NUMBER_MAX is JavaScript's Number.MAX_SAFE_INTEGER, right? The following documentation seems to indicate that 9007199254740991 (9007199254740991L) is the correct value.
The Number.MAX_SAFE_INTEGER constant represents the maximum safe integer in JavaScript (2^53 - 1).
vvatanabe
reviewed
Apr 5, 2022
| if (n < 2) return 1; | ||
| int f = 1; | ||
| if (n > 19) return JS_NUMBER_MAX; |
There was a problem hiding this comment.
Notes:
n is 18 => 6402373705728000
JS_NUMBER_MAX => 9007199254740991
n is 19 => 121645100408832000
|
@InkerBot Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #54