Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactoring matchers.DateMatcher #144

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Conversation

vvatanabe
Copy link
Member

refactoring matchers.DateMatcher:

  • Extracted part of the process within the execute function into a separate function.
  • Applied google-java-format.
  • DATE_SPLITS was converted to an array. With this change, access to DATE_SPLITS is faster, eliminating the need for hash computations and key lookups.

@vvatanabe vvatanabe merged commit 133b326 into master Aug 15, 2023
2 checks passed
@vvatanabe vvatanabe deleted the refactoring-DateMatcher branch August 15, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant