Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improved SpatialMatcher decision logic (#84) (#129) #147

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: improved SpatialMatcher decision logic (#84) (#129) #147

merged 1 commit into from
Aug 18, 2023

Conversation

vvatanabe
Copy link
Member

Describe the change

Improved SpatialMatcher decision logic.

Describe your solution

  • The decision logic of SpatialMatcher's lastDirection has been made consistent with the origin.
  • Match the increment logic of the guess value in SpatialGuess with the origin.

Tests

Added "Sigma@123" and "password@123" to JavaPortTest parameters.

Additional context

Issue: #84 #129

@vvatanabe vvatanabe merged commit 91deed7 into main Aug 18, 2023
2 checks passed
@vvatanabe vvatanabe deleted the fix-the-discrepancy-in-password-scores-between-zxcvbn-and-zxcvbn4j branch August 18, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vvatanabe