Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the InvocationTargetException when running tests with Gradle #42

Merged
merged 1 commit into from
Jan 13, 2018

Conversation

sainaen
Copy link
Contributor

@sainaen sainaen commented Jan 12, 2018

Static inner class ExpectedMatch was annotated with @org.junit.Ignore.
This broke assumptions of the JUnit4Runner expecting to find a test class
when Gradle tries to enumerate ignored tests. Making it private instead of ignoring
solves the problem.

For example, here's the exception in the latest (passing) build: build 95.

@sainaen
Copy link
Contributor Author

sainaen commented Jan 12, 2018

Oh, Travis-CI is failing since #40 is not fixed yet. I'll rebase on the latest master when it's addressed.
A-a-and it's done.

@sainaen sainaen force-pushed the fix-gradle-invocation-ex branch 2 times, most recently from f1517ee to 4d124cd Compare January 12, 2018 14:28
Static inner class ExpectedMatch was annotated with @org.junit.Ignore.
Since it's not a test, using @ignore breaks assumptions of the JUnit4Runner
when Gradle tries to enumerate ignored tests.
@vvatanabe
Copy link
Member

Thanks too!

@vvatanabe vvatanabe merged commit f6bb79b into nulab:master Jan 13, 2018
@sainaen sainaen deleted the fix-gradle-invocation-ex branch January 13, 2018 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants