Improve extensibility of Zxcvbn and Matching and optimize memory usage #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use singleton empty collections where possible, prefer conversions from an array to a list avoiding array copy and prefer HashMap copy constructor to manual copy.
Previously the only way how to provide custom dictionaries was by using `sanitizedInputs` argument of `Zxcvbn#measure(String, List<String>)` method. The disadvantage was that the custom dictionary was reprocessed for every call and for large custom dictionary it could incur considerable overhead. To improve the situation, Zxcvbn class is modified to allow supplying custom instance of Matching class and also Matching class is changed to allow the needed level of extensibility. This extensibility changes maintain full backward compatibility.
|
@psvo Thanks for great PR. I will chk it ASAP! |
|
@psvo I would appreciate your reply to my comment. |
|
@vvatanabe Hi, I'm sorry, but I don't see any comment, where you asked me something. Can you point me in the right direction? Thx. |
vvatanabe
requested changes
Feb 26, 2018
| } | ||
|
|
||
| public List<Match> omnimatch(String password) { | ||
| return new OmnibusMatcher(rankedDictionaries).execute(password); | ||
| } | ||
|
|
||
| private static Map<String, Integer> buildRankedDict(String[] orderedList) { | ||
| protected static Map<String, Integer> buildRankedDict(List<String> orderedList) { |
There was a problem hiding this comment.
@psvo
I have a question. Why did you change from array to list?
There was a problem hiding this comment.
Because we need to pass an array only when building system dictionaries. Using Arrays.asList does not copy underlining array, just wraps it. For orderedList (user inputs), we natively have a list. So I wanted to avoid copying it to an array. This way we save array allocation and avoid one iteration over orderedList in the hot path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
ZxcvbnandMatchingclasses to make extending their behavior possible without changing current public API. The main idea is to allow usage of custom (extended)Matchingclass withZxcvbn.One of possible uses is implementing support for custom user dictionary that is parsed/processed just once and then reused for subsequent calls to
Zxcvbn#measure(String, List<String>). Passing large user dictionary to each call of measure causes noticeable slowdown and generates unnecessary GC overhead.Also includes optimizations avoiding unnecessary allocations for standard use cases.