Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #45 that ResourceBundle.Control is not supported in named modules #46

Merged

Conversation

kasecato
Copy link
Contributor

You can't use ResourceBundle.Control if you're using modules with JDK 9 or later. This library does not support JDK 9, so I can't write test code, sorry.

ResourceBundle.Control is not supported in named modules. If the getBundle method with a ResourceBundle.Control is called in a named module, the method will throw an UnsupportedOperationException
https://docs.oracle.com/javase/9/docs/api/java/util/ResourceBundle.html#bundleprovider

@vvatanabe
Copy link
Member

@kasecato Thank you for the great PR. LGTM ;D

@vvatanabe vvatanabe merged commit 40ff2e1 into nulab:master Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants