Use system class loader to access resources #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There seems to be an issue with the CI config, unrelated to this PR |
|
I made a PR on #57 to avoid the error. |
|
Thanks @tsuyoshizawa, pulled in the changes from |
|
@simonschiller @tsuyoshizawa |
|
@vvatanabe Are you going to make a release with this change any soon? |
|
@rom4ek I will release it next week. |
|
@rom4ek @simonschiller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When this library is obfuscated, loading resources using a relative path might not work anymore (was the case for us). Therefore we had to exclude those classes from being obfuscated. This change uses absolute paths to load resources, so there is no client-side configuration needed to work with code obfuscation tools.