Fix #2 #6
Merged
Fix #2 #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvatanabe
added a commit
that referenced
this pull request
Jan 28, 2016
Thanks for your PR, this code is very clean. It will upload to maven central. I feel so lucky to be with you. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
Feedbacksetters are not required, I've got rid of them. That enabled me to get rid ofFeedback.Messageclass as well.Also I've added
Feedback.withResourceBundlemethod and this actually fixes my issue about l10n.Now I don't feel guilty about overengineering in you pure code.