Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some utility functions added #13

Merged
merged 12 commits into from
Jan 12, 2024
Merged

Some utility functions added #13

merged 12 commits into from
Jan 12, 2024

Conversation

ssrlive
Copy link
Contributor

@ssrlive ssrlive commented Sep 28, 2023

Adapter::set_adapter_mtu
Adapter::set_dns_servers
get_active_network_interface_gateways
run_command

@ssrlive
Copy link
Contributor Author

ssrlive commented Dec 31, 2023

Hi @TroyNeubauer , please review this PR. If there exist some problems, please point out.

Copy link
Collaborator

@TroyNeubauer TroyNeubauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these! Some notes about logging and the public api, but looks good overall

src/lib.rs Outdated Show resolved Hide resolved
src/session.rs Outdated Show resolved Hide resolved
src/util.rs Show resolved Hide resolved
src/util.rs Show resolved Hide resolved
@ssrlive
Copy link
Contributor Author

ssrlive commented Jan 11, 2024

Applied all suggestions. Please review it and then publish it. Thanks.

Copy link
Collaborator

@TroyNeubauer TroyNeubauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TroyNeubauer TroyNeubauer merged commit 470803a into nulldotblack:main Jan 12, 2024
5 checks passed
@TroyNeubauer TroyNeubauer mentioned this pull request Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants