Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support an optional name option for most constraints #23

Merged
merged 1 commit into from
Mar 29, 2017

Conversation

pjungwir
Copy link
Contributor

No description provided.

Copy link
Owner

@nullobject nullobject left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

@nullobject nullobject merged commit 86de42f into nullobject:master Mar 29, 2017
@nullobject
Copy link
Owner

Oops, I just realised that the remove_*_constraint function will need to be updated to support name also.

@pjungwir
Copy link
Contributor Author

Good point! I'll give you a PR for that too... :-)

@nullobject
Copy link
Owner

All good, I've fixed it up already :)

@pjungwir
Copy link
Contributor Author

Okay, great!

That PR for testing against a real database also adds an options hash to each remove_* method, so it might need rebasing now. Let me know over there what you think of it! I'm eager to work on revertible methods but want those tests first.

@nullobject
Copy link
Owner

Will do, I'm at work right now so I probably won't get a chance until later tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants