Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbreak build on FreeBSD #3

Merged
merged 2 commits into from
Dec 22, 2021
Merged

Unbreak build on FreeBSD #3

merged 2 commits into from
Dec 22, 2021

Conversation

jbeich
Copy link
Contributor

@jbeich jbeich commented Dec 21, 2021 •
edited
Loading

Packaged

$ pkg install pass-secrets
$ pass init <my-key>
$ daemon -f pass-secrets

$ secret-tool store --label=test foo bar

$ lssecret
Collection:     Default Keyring

Item:   test
Key:    foo
Value:  bar

$ secret-tool search foo bar
[/org/freedesktop/secrets/collection/ALl1D6BvtyxGuoI6bO2N7/Y8aYEwmavsxeKKfBmiWWb]
label = test
secret = abc
created = 2021-12-21 00:01:04
modified = 2021-12-21 00:01:04
attribute.foo = bar

@jbeich
interop: add missing include for libc++
1381a09 
interop/PassStore.cpp:52:23: error: implicit instantiation of undefined template 'std::basic_stringstream<char>'
                stringstream path = stringstream(getenv("PATH"));
                                    ^
/usr/include/c++/v1/iosfwd:142:32: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS basic_stringstream;
                               ^
interop/PassStore.cpp:52:16: error: implicit instantiation of undefined template 'std::basic_stringstream<char>'
                stringstream path = stringstream(getenv("PATH"));
                             ^
/usr/include/c++/v1/iosfwd:142:32: note: template is declared here
    class _LIBCPP_TEMPLATE_VIS basic_stringstream;
                               ^
@jbeich
include: explicitly define environ for BSDs
01cc706 
In file included from interop/PassItem.cpp:11:
include/subprocess.h:821:90: error: use of undeclared identifier 'environ'
        if (int err{::posix_spawnp(&pid, sh.argv()[0], action.get(), nullptr, sh.argv(), environ)}; err != 0)
                                                                                         ^

See also https://git.musl-libc.org/cgit/musl/commit/?id=d200bd727bea
https://pubs.opengroup.org/onlinepubs/9699919799/functions/V2_chap02.html#tag_15_02_02 says:
> All identifiers in this volume of POSIX.1-2017, except `environ`,
> are defined in at least one of the headers, as shown in XBD Headers.
@nullobsi nullobsi merged commit e91a1b3 into nullobsi:main Dec 22, 2021
@nullobsi
Copy link
Owner

looks good! thanks for submitting :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbeich @nullobsi