Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inapp updater bug #119

Closed
3 tasks done
rinme opened this issue May 30, 2023 · 5 comments
Closed
3 tasks done

Inapp updater bug #119

rinme opened this issue May 30, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@rinme
Copy link
Contributor

rinme commented May 30, 2023

Type

UI-related issues

Bug description

Inapp updater is download the apk but not install.

Steps to reproduce

  1. Open information
  2. Download update

Android version

Android 11

App version

1.3.8
And probably 1.3.9 wouldn't fix

Screenshots or videos

Screenshot_20230530-224847
Screenshot_20230530-224851

Solution

Add the prompt to ask if want to install now to open system installer prompt (I knew it sounds more step for ux), Or maybe unlock the notification to able to press to install in case the auto install is messed.

Additional context

No response

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@rinme rinme added the bug Something isn't working label May 30, 2023
@nullxception
Copy link
Owner

does it happen only when device is unlocked ?
cause currently there's no way to add functionality to the download notification (flutter downloader thing).

@rinme
Copy link
Contributor Author

rinme commented May 30, 2023

does it happen only when device is unlocked ?
cause currently there's no way to add functionality to the download notification (flutter downloader thing).

Yes, It happened both unlocked and locked. The app can't get the installer if have multi installer (I guess, aka SAI)

@nullxception
Copy link
Owner

does it happen only when device is unlocked ?
cause currently there's no way to add functionality to the download notification (flutter downloader thing).

Yes, It happened both unlocked and locked. The app can't get the installer if have multi installer (I guess, aka SAI)

ah I see what's happening, thanks for clarifying

@sam-gq
Copy link

sam-gq commented Jun 5, 2023

I have the same thing when using built-in updater but it's a minor complaint when using this. There is no option to change location to /Download folder of downloaded apk to update the app.

But instead, the downloaded apk stored inside the app data can't be deleted or even clear cache the app to free up space when before I forgot to update the app. So I ended up to clear data this app, restore my progress and tried to update again.

Do you have any consideration @nullxception, storing updated apk files to the downloads folder instead of the in-app data itself? It is the first time to comment in this project.

@nullxception
Copy link
Owner

nullxception commented Jun 5, 2023

I have the same thing when using built-in updater but it's a minor complaint when using this. There is no option to change location to /Download folder of downloaded apk to update the app.

But instead, the downloaded apk stored inside the app data can't be deleted or even clear cache the app to free up space when before I forgot to update the app. So I ended up to clear data this app, restore my progress and tried to update again.

Do you have any consideration @nullxception, storing updated apk files to the downloads folder instead of the in-app data itself? It is the first time to comment in this project.

Uhm, the app already does that for you. The app will be downloading the apk to app cache first, and then when update completed, it's automatically moved to /sdcard/Downloads/Boorusphere/app-update/ folder.

The actual bug on 1.3.8 and 1.3.9 is, the app_updater did not properly connected to the flutter_downloader API.
so even if the apk download has been performed, the app just doesn't get any information about it at all, it's like nothing happens.

It's fixed on 1ac3ea9 already, so next release should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants