Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Open navbar links in new tab #1077

Merged

Conversation

allank-nulogy
Copy link
Contributor

Description

This allows us to configure links inside the BrandedNavBar component to open in a new tab, using the openOnNew property of a menu item.

Changes include

  • breaking change: a change that is not backwards-compatible and/or changes current functionality
  • fix: a non-breaking change that solves an issue
  • feature: a non-breaking change that adds functionality
  • chore: contains no changes affecting the library, such as documentation or test updates

Feature checklist

  • Appropriate tests have been added
  • Documentation has been updated
  • Accessibility has been considered

@haideralsh haideralsh merged commit 845e6e3 into master Feb 16, 2023
@haideralsh haideralsh deleted the PM-11226-update-brandednavbar-to-open-links-in-new-window branch February 16, 2023 14:48
github-actions bot pushed a commit that referenced this pull request Feb 16, 2023
# [8.7.0](v8.6.0...v8.7.0) (2023-02-16)

### Features

* Open navbar links in new tab ([#1077](#1077)) ([845e6e3](845e6e3))
@github-actions
Copy link

🎉 This PR is included in version 8.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants