fix: NDS Select props are broken #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
react-windowed-select does not forward <Option, IsMulti extends boolean, Group extends GroupBase<Option>> downstream to the react-select resulting in mismatches between the expected types (defaulting to unknown) and the actual types inferred by react-select. This caused a problem for both the onChange and the custom components.
haideralsh
force-pushed
the
fix-nds-select-types
branch
from
45c8fbf
to
750ca4f
Compare
jherdman
reviewed
May 16, 2024
haideralsh
force-pushed
the
fix-nds-select-types
branch
from
97cce89
to
c103297
Compare
haideralsh
force-pushed
the
fix-nds-select-types
branch
from
c103297
to
6759388
Compare
haideralsh
force-pushed
the
fix-nds-select-types
branch
from
6759388
to
e08abcf
Compare
jherdman
approved these changes
May 17, 2024
haideralsh
added a commit
that referenced
this pull request
May 22, 2024
BREAKING CHANGE: removes the ability to pass custom props to the Select component. * feat: remove react-windowed-select * feat: Roll our own windowing Select * chore: Inline react-select license * chore: remove smoothscroll-polyfill: https://caniuse.com/css-scroll-behavior
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
# [11.0.0-beta.1](v10.2.4...v11.0.0-beta.1) (2024-05-22) ### Bug Fixes * NDS Select props are broken ([#1408](#1408)) ([bc42a90](bc42a90)) ### BREAKING CHANGES * removes the ability to pass custom props to the Select component. * feat: remove react-windowed-select * feat: Roll our own windowing Select * chore: Inline react-select license * chore: remove smoothscroll-polyfill: https://caniuse.com/css-scroll-behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempting to fix the NDSSelect Props
Changes include
Feature checklist