Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: NDS Select props are broken #1408

Merged
merged 8 commits into from
May 21, 2024
Merged

fix: NDS Select props are broken #1408

merged 8 commits into from
May 21, 2024

Commits on May 9, 2024

  1. wip

    @haideralsh
    haideralsh committed May 9, 2024
    Configuration menu
    Copy the full SHA
    5b608c9 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. fix: remove all generics from NDSSelect 

    react-windowed-select does not forward <Option, IsMulti extends boolean, Group extends GroupBase<Option>>
downstream to the react-select resulting in mismatches between the expected types (defaulting to unknown)
and the actual types inferred by react-select.

This caused a problem for both the onChange and the custom components.
    @haideralsh
    haideralsh committed May 10, 2024
    Configuration menu
    Copy the full SHA
    750ca4f View commit details
    Browse the repository at this point in the history

Commits on May 15, 2024

  1. feat: remove react-windowed-select

    @haideralsh
    haideralsh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    e8f2204 View commit details
    Browse the repository at this point in the history

  2. feat: Roll our own windowing Select

    @haideralsh
    haideralsh committed May 15, 2024
    Configuration menu
    Copy the full SHA
    115122c View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. change the placeholder

    @haideralsh
    haideralsh committed May 16, 2024
    Configuration menu
    Copy the full SHA
    e47cf69 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. fix: exclude only overridden types

    @haideralsh
    haideralsh committed May 17, 2024
    Configuration menu
    Copy the full SHA
    183eaf2 View commit details
    Browse the repository at this point in the history

  2. Inline react-select license

    @haideralsh
    haideralsh committed May 17, 2024
    Configuration menu
    Copy the full SHA
    435a8de View commit details
    Browse the repository at this point in the history

  3. chore: remove smoothscroll-polyfill 

    https://caniuse.com/css-scroll-behavior
    @haideralsh
    haideralsh committed May 17, 2024
    Configuration menu
    Copy the full SHA
    e08abcf View commit details
    Browse the repository at this point in the history