Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quarto filetype and enable languages using other languages' parsers #301

Merged
merged 3 commits into from Feb 13, 2023

Conversation

jmbuhr
Copy link
Contributor

@jmbuhr jmbuhr commented Jan 29, 2023

This requires the nvim-treesiter plugin, as the quarto filetype does not yet have its own treesitter grammar, and this now merged PR in nvim-treesitter: https://github.com/nvim-treesitter/nvim-treesitter/pull/4212/files

It also makes Comment.nvim work for the other languages in the same list:

https://github.com/nvim-treesitter/nvim-treesitter/blob/cda8b291ef6fc4e04036e2ea6cf0de8aa84c2656/lua/nvim-treesitter/parsers.lua#L4-L23

lua/Comment/ft.lua Outdated Show resolved Hide resolved
@numToStr numToStr merged commit 418d311 into numToStr:master Feb 13, 2023
@jmbuhr jmbuhr deleted the quarto-ft branch February 13, 2023 10:37
@numToStr
Copy link
Owner

Good news! After the following PRs we might not even need that filetype mapping table, but we might need to wait for next stable neovim release.

@jmbuhr
Copy link
Contributor Author

jmbuhr commented Feb 23, 2023

That's great news!

numToStr added a commit that referenced this pull request Apr 11, 2023
This PR removes the workaround needed for converting filetype to parser
name. Neovim now provides proper API to deal with this ambiguity, which
is also respected by nvim-treesitter and for most cases this conversion
is automatic.

This was introduced in 
- #301

Supersedes #326
Fixes #325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants