changes to numa_node_size breaks program

[DE0CH]

In commit a7c4bc7 the signature of the function is changed from

long numa_node_size(int node, long *freep)

to

long long numa_node_size(int node, long long *freep);

causing any program that uses this this function to fail to compile.

While I see that this is done to prevent overflow, it shouldn't be introduced in a maintenance release. Since it is backward incompatible, it should be included in the next major release according to Semantic Versioning.

[andikleen]

On Fri, Sep 16, 2022 at 05:50:18PM +0000, Deyao Chen wrote: In commit a7c4bc7 the signature of the function is changed from long numa_node_size(int node, long *freep) to long long numa_node_size(int node, long long *freep); causing any program that uses this this function to fail to compile. While I see that this is done to prevent overflow, it shouldn't be introduced in a maintenance release. Since it is backward incompatible, it should be included in the next major release according to Semantic Versioning.

Agreed. I will revert it.

[thesamesam]

Using abidiff may help to find problems like this.

[filbranden]

Resolved with release of 2.0.16

[thesamesam]

Using abidiff may help to find problems like this.

I should've elaborated a bit, here's some examples of how projects do it in CI: Matroska-Org/libebml#104 (comment). Cheers!