numastat: statistical errors occur when huge pages is used #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because when we calculate the huge pages memory, we use the default huge page size, it maybe get worng. After linux commit 198d1597cc5a1(fs: proc: task_mmu: show page size in /proc//numa_maps), we can obtain the correct VM page size, so we can fix it.
andikleen
approved these changes
Dec 14, 2022
| double vm_pagesz = 0; | ||
| char *pagesz_str = strstr(buf, VM_PGSZ_STR); | ||
| if (pagesz_str) { | ||
| vm_pagesz = (double)strtol(&pagesz_str[VM_PGSZ_STRLEN], NULL, 10); |
There was a problem hiding this comment.
Please avoid double. Just unsigned long or long long
| @@ -1021,11 +1031,13 @@ static void show_process_info(void) | |||
| exit(EXIT_FAILURE); | |||
| } | |||
| double value = (double)strtol(&p[1], &p, 10); | |||
| double multiplier = page_size_in_bytes; | |||
There was a problem hiding this comment.
Oh I see it's already double.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#147
Because when we calculate the huge pages memory, we use the default huge page size, it maybe get worng.
After linux commit 198d1597cc5a1(fs: proc: task_mmu: show page size in /proc//numa_maps), we can obtain the correct VM page size, so we can fix it.