numactl: Fix shm verfiy for preferred policy #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2022 22:54
The following command can report verify bug:
numactl --length=4096 --shm abc -p0 --verify
when policy uses perferred, set_policy isn't set.
Fixes: 0c844d8("Update to support multiple nodes")
When preferred is used for shm, no value is assigned to the variable node, As a result, it does not take effect. fixes: 5862e0e("numactl: Simplify preferred selection")
|
@andikleen please review. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following command can report "numactl: Need a policy first to verify"
when policy uses perferred, set_policy isn't set.
Fixes: 0c844d8("Update to support multiple nodes")
#155
'numactl --length=xxx --shm xxx -px' doesn't work
When preferred is used for shm, no value is assigned to the variable node.
As a result, it does not take effect.
fixes: 5862e0e("numactl: Simplify preferred selection")
#158