forked from ovn-org/ovn
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
controller: Avoid use after free in LB I-P.
Avoid use after free in scenario when controller received LB deletion after the DB was reconnected. The reconnect led to idl clearing up the "old" structs, one of them being the LB. However, during recompute the struct was referenced when it was already gone. Clear the whole objdep_mgr instead of going one-by-one during recompute. ==143949==ERROR: AddressSanitizer: heap-use-after-free READ of size 4 at 0x5130000280d0 thread T0 0 0x61c3c9 in lb_data_local_lb_remove controller/ovn-controller.c:2978:5 1 0x5fd4df in en_lb_data_run controller/ovn-controller.c:3063:9 2 0x6fe0d9 in engine_recompute lib/inc-proc-eng.c:415:5 3 0x6fbdc2 in engine_run_node lib/inc-proc-eng.c:477:9 4 0x6fbdc2 in engine_run lib/inc-proc-eng.c:528:9 5 0x5f39a0 in main controller/ovn-controller.c Fixes: 8382127 ("controller: Store load balancer data in separate node") Reported-at: https://issues.redhat.com/browse/FDP-610 Signed-off-by: Ales Musil <amusil@redhat.com> Signed-off-by: Numan Siddique <numans@ovn.org> (cherry picked from commit e5d093c)
- Loading branch information
1 parent
bc2af6a
commit 0440a08
Showing
2 changed files
with
48 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters