Skip to content

Commit

Permalink
Fixed lint check
Browse files Browse the repository at this point in the history
Signed-off-by: chandankumar4 <chandan.kr404@gmail.com>
  • Loading branch information
chandankumar4 committed Oct 30, 2023
1 parent 6b7f268 commit 7247d38
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
19 changes: 11 additions & 8 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -96,26 +96,29 @@ jobs:
echo /home/runner/go/bin >> $GITHUB_PATH
echo /usr/local/bin >> $GITHUB_PATH
- name: "Step 5: Create a registry and a cluster"
- name: "Step 5: Install k3d"
run: curl -s https://raw.githubusercontent.com/k3d-io/k3d/main/install.sh | bash

- name: "Step 6: Create a registry and a cluster"
run: |
k3d registry create e2e-registry --port 5111
k3d cluster create e2e --registry-use k3d-e2e-registry:5111
k3d kubeconfig get e2e > ~/.kube/numaflow-e2e-config
echo '127.0.0.1 k3d-e2e-registry' | sudo tee -a /etc/hosts
- name: "Step 6: Load image in cluster"
- name: "Step 7: Load image in cluster"
run: |
docker load --input /tmp/aws-sqs-queue.tar
k3d image import "quay.io/numaio/numaproj-contrib/aws-sqs-sink-go:sqs-e2e"
docker load --input /tmp/aws-sqs-queue-image.tar
k3d image import "quay.io/numaio/numaproj-contrib/aws-sqs-sink-go:sqs-e2e" --cluster e2e
- name: "Step 7: Install Numaflow"
- name: "Step 8: Install Numaflow"
env:
KUBECONFIG: "~/.kube/numaflow-e2e-config"
KUBECONFIG: ~/.kube/numaflow-e2e-config
run: make install-numaflow

- name: "step 8: Run E2E tests"
- name: "step 9: Run E2E tests"
env:
KUBECONFIG: "~/.kube/numaflow-e2e-config"
KUBECONFIG: ~/.kube/numaflow-e2e-config
# These values are for moto configuration, ref: https://docs.getmoto.org/en/latest/
AWS_REGION: "us-east-1"
AWS_ACCESS_KEY_ID: "testing"
Expand Down
5 changes: 0 additions & 5 deletions test/fixtures/when.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,6 @@ type When struct {
pipeline *dfv1.Pipeline
restConfig *rest.Config
kubeClient kubernetes.Interface

portForwarderStopChannels map[string]chan struct{}
// Key: vertex label selector
// Value: the ip of, one of the pods matching the label selector
vertexToPodIpMapping map[string]string
}

func (w *When) CreateISBSvc() *When {
Expand Down

0 comments on commit 7247d38

Please sign in to comment.