Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce testing utility dependency #3

Merged
merged 5 commits into from
Oct 31, 2023

Conversation

KeranYang
Copy link
Contributor

No description provided.

@chandankumar4
Copy link
Contributor

chandankumar4 commented Oct 31, 2023

@KeranYang I need to get this #2 PR merged to fix the pipeline failure, after than I can verify this PR changes.

Probably I need to make some change related to deploying moto service, which was done from setup suite in my case. Also redis and e2e-pod is not required but this fixture will deploy that also as it won't harm but taking extra resource and time to run.

@KeranYang
Copy link
Contributor Author

redis and e2e-pod is not required

Agreed. I am keeping them for now just in case there is future use cases. Will monitor and see if maintaining them increases engineer efforts, if so I will remove them.

@chandankumar4
Copy link
Contributor

If you can resolve the conflict, then we can merge this PR but e2e test will fail, I'll raise another PR to fix it?

Signed-off-by: Keran Yang <yangkr920208@gmail.com>
.
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang
Copy link
Contributor Author

@chandankumar4 on your next PR, could you remove the dependency on github.com/numaproj/numaflow v0.11.0 ? Let's create our own logger from scratch. The rationale is that numaflow is not a library and UDSink should only depend on numaflow-go sdk.

Signed-off-by: Keran Yang <yangkr920208@gmail.com>
.
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
.
Signed-off-by: Keran Yang <yangkr920208@gmail.com>
@KeranYang KeranYang merged commit 636b47c into numaproj-contrib:main Oct 31, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants