refactor: depend on numaflow to use native nats configuration struct #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change brings the following benefits:
Not so good:
One can argue that this brings in a circular dependency where NATS UDSource depends on Numaflow platform code while Numaflow depends on the NATS UDSource to run its built-in NATS source. However, the second dependency is simply a dependency on the image instead of a code dependency so it should be fine.