Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling auto-heal should prevent Auto-healing even if I make a commit #261

Open
juliev0 opened this issue Apr 30, 2024 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@juliev0
Copy link
Collaborator

juliev0 commented Apr 30, 2024

Describe the enhancement

Currently, if we turn off auto-healing, it won't prevent auto-healing if somebody makes a commit. Once the commit occurs, the auto-syncing does everything including auto-healing.

Scenario: If auto heal is off, I'm a user, and I manually update my Deployment resource in the cluster but then I change my ConfigMap spec in github, I want my ConfigMap to get updated but I don't want my Deployment to be auto-healed.

Edit: I just spoke to someone from ArgoCD who says the behavior actually does match our current behavior (although they also have an option of doing a Partial Sync manually I guess). So, I've listed this as an enhancement instead.


Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

@juliev0 juliev0 added the bug Something isn't working label Apr 30, 2024
@juliev0 juliev0 added enhancement New feature or request and removed bug Something isn't working labels May 7, 2024
@juliev0
Copy link
Collaborator Author

juliev0 commented May 7, 2024

@xdevxy I changed this to "enhancement" as you imagined it should be. I just spoke to someone from ArgoCD who says the behavior actually does match our current behavior (although they also have an option of doing a Partial Sync manually I guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant