Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numaplane asset changes for API Gateway AuthZ to GitHub Proxy #269

Open
afugazzotto opened this issue May 2, 2024 · 2 comments
Open

Numaplane asset changes for API Gateway AuthZ to GitHub Proxy #269

afugazzotto opened this issue May 2, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@afugazzotto
Copy link
Collaborator

afugazzotto commented May 2, 2024

Summary

Currently, the GitHub Proxy relies on a sandboxed service (https://devportal.intuit.com/app/dp/resource/1876892738027973285) for API Gateway or Mesh authorization. We need to use and configure this asset instead https://devportal.intuit.com/app/dp/resource/5263599657741369597/overview.
Then, we need to update the numa-manifest-generator with the new IDPS policyID and other needed config changes.

Changes will include

  • service preprod and prod deployment
  • creation of a new offline job (one per env)
  • IDPS secrets setup on all envs for appID, appSecret, and jobID with Access Control for arn:aws:iam::926113353675:role/numaplane
  • downstream services onboarding: API Gateway, AuthZ Decision Service, Identity API Private, numaproxy

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@afugazzotto afugazzotto added the enhancement New feature or request label May 2, 2024
@afugazzotto afugazzotto self-assigned this May 2, 2024
@afugazzotto
Copy link
Collaborator Author

This may no longer be needed if we do not use API Gateway and since we will use https://devportal.intuit.com/app/dp/resource/5263599657741369597/overview for the asset alias needed for the Mesh setup by the Mesh team as per discussion with Anil. @juliev0 can you confirm that this is the correct asset we will use and we do not need to create a new one?

@juliev0
Copy link
Collaborator

juliev0 commented May 3, 2024

https://devportal.intuit.com/app/dp/resource/5263599657741369597/overview

So, if the question is whether I think we can continue to use our Numaplane Asset in our Controller's annotations:

annotations:
        sidecar.istio.io/inject: "true"
        policyId: "{{.MeshPolicyID}}"
        alpha.istio.io/identity: "Intuit.oss.analytics.numaplane"

then I am not aware of a reason why we can't.

Please note that this same Asset is referenced in our Namespace itself.

@afugazzotto afugazzotto changed the title Official GitHub Proxy Gateway/Companion service Numaplane asset changes for API Gateway AuthZ to GitHub Proxy May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants