feat: Add ID and numDelivered fields to Datum in udf #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hao Hao <xdevxhao@gmail.com>
Signed-off-by: Hao Hao <xdevxhao@gmail.com>
KeranYang
approved these changes
Apr 13, 2023
Comment on lines
+10
to
+16
| public String getId() { | ||
| return this.id; | ||
| } | ||
|
|
||
| public long getNumDelivered() { | ||
| return this.numDelivered; | ||
| } |
There was a problem hiding this comment.
nit: L10-16 can be removed by adding lombok @Getter annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of numaproj/numaflow#538, this PR adds ID and numDelivered fields to Datum in udf, so that users are exposed with these metadata information about the message.
It also upgrades
lombokto1.18.26because of projectlombok/lombok#3264.