Skip to content

Commit

Permalink
fix: ack the dropped messages as well (#603)
Browse files Browse the repository at this point in the history
Signed-off-by: ashwinidulams <ashttk@gmail.com>
  • Loading branch information
ashwinidulams authored and whynowy committed Mar 13, 2023
1 parent 4cdef17 commit 16b20a3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions pkg/reduce/readloop/readloop.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ messagesLoop:
metrics.LabelPipeline: rl.pipelineName,
metrics.LabelVertexReplicaIndex: strconv.Itoa(int(rl.vertexReplica)),
LabelReason: "late"}).Inc()

// mark it as a successfully written message as the message will be acked to avoid subsequent retries
writtenMessages = append(writtenMessages, message)
continue
}

Expand Down

0 comments on commit 16b20a3

Please sign in to comment.