Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sources have metadata associated with payload and we need to propagate those along with the payload #1568

Closed
vigith opened this issue Mar 15, 2024 · 1 comment · Fixed by #1578
Labels
area/source enhancement New feature or request
Milestone

Comments

@vigith
Copy link
Contributor

vigith commented Mar 15, 2024

Summary

Numaflow source should have a way to propagate headers (e.g., Kafka Record Headers, HTTP Headers, etc.) along with the payload. The only way it is possible today is by passing the headers along with the payload after encoding it in JSON.


We could perhaps pass it in ISB.Header and expose it via the Metadata interface. This is not a clean approach because only sources have metadata and could be dropped after the first hop (transformer, Map UDF, etc.).

Another approach is not to include and let users write custom User-defined sources if they need to access that data. The most significant side effect is the need for sharability of commonly used sources, and hence, it is not worthwhile to reimplement them repeatedly.

Use Cases

Needs to access Header in processing vertex because they contain valuable metadata.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@vigith
Copy link
Contributor Author

vigith commented Mar 15, 2024

depends on #1572

@vigith vigith added this to the 1.3 milestone Mar 15, 2024
@vigith vigith modified the milestones: 1.3, 1.2 Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/source enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant