Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Headers KV[string]string from source to sink #1572

Closed
8 tasks done
vigith opened this issue Mar 15, 2024 · 0 comments · Fixed by #1578
Closed
8 tasks done

Pass Headers KV[string]string from source to sink #1572

vigith opened this issue Mar 15, 2024 · 0 comments · Fixed by #1578
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@vigith
Copy link
Contributor

vigith commented Mar 15, 2024

Summary

ISB.Header should support an additional field which a map of key, value of String type. Since headers are part of the data, the Datum, we should expose Datum.GetHeaders() method that returns KV[string]string.

Use Cases

  • Sources like HTTP, Kafka, etc., have headers and UDFs want to access those
  • Distributed Tracing
  • Ability to pass transaction-id(tx_id), auth_headers, etc.

Notes

It is easy to propagate for Map vertices, but for Reduce, we cannot do a merge of many to one, hence it is okay to create an empty header after the Reduce operation.


Numaflow

SDK Tracking

  1. area/sdk
    yhl25
  2. area/sdk
    yhl25
  3. area/sdk
    yhl25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants