Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom init containers for vertex pods #284

Closed
dseapy opened this issue Oct 29, 2022 · 3 comments · Fixed by #285
Closed

Custom init containers for vertex pods #284

dseapy opened this issue Oct 29, 2022 · 3 comments · Fixed by #285
Labels
enhancement New feature or request opex Operational Excellence to make it easy to run in production and debug

Comments

@dseapy
Copy link
Contributor

dseapy commented Oct 29, 2022

Summary

Add the ability for users to add init containers to the udf pods.

Use Cases

Currently the udf container is responsible for downloading the ML model. Instead it would be preferred for my use-case if there was an init-container (maintained by devops, not data-scientists developing the udf containers) that was responsible for acquiring the model and sharing it with the udf container through a volumemount. This provides a couple advantages:

  • Ensures consistency for configuration/implementation of acquiring the model.
  • Provides an easy way to migrate if/when storage implementation changes (i.e. custom s3 endpoint, move from s3 to another storage provider, etc).
  • Simplifies debugging & any required fixes by devops in case there are network-related issues, since they own a single container.

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@dseapy dseapy added the enhancement New feature or request label Oct 29, 2022
@dseapy
Copy link
Contributor Author

dseapy commented Oct 29, 2022

Alternatively, if numaflow provided a way to provide files from object storage to udf pods, that would be simpler than custom init-containers for the model-download use-case. Maybe it makes sense to make a ticket for that instead/in-addition? Maybe in-addition, as there may be other use-cases in the future for which specifying more custom init containers would be useful.

@vigith vigith added the opex Operational Excellence to make it easy to run in production and debug label Oct 29, 2022
@vigith
Copy link
Member

vigith commented Oct 29, 2022

I would think giving custom init containers is better than our code abstracting out the download of objects. If we are to abstract, we will be strictly limiting our use cases.

@whynowy
Copy link
Member

whynowy commented Oct 29, 2022

I would think giving custom init containers is better than our code abstracting out the download of objects. If we are to abstract, we will be strictly limiting our use cases.

Agreed.

dseapy added a commit to dseapy/numaflow that referenced this issue Oct 29, 2022
Signed-off-by: David Seapy <dseapy@gmail.com>
@dseapy dseapy changed the title Custom init containers for udf pods Custom init containers for vertex pods Oct 30, 2022
whynowy pushed a commit that referenced this issue Nov 7, 2022
Signed-off-by: Derek Wang <whynowy@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request opex Operational Excellence to make it easy to run in production and debug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants