Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit test core code paths in reduce #373

Closed
Tracked by #231
vigith opened this issue Nov 19, 2022 · 0 comments · Fixed by #377
Closed
Tracked by #231

Unit test core code paths in reduce #373

vigith opened this issue Nov 19, 2022 · 0 comments · Fixed by #377
Assignees
@yhl25
Labels
area/reduce Reduce operations like GroupByKey testing Testing and CI

Comments

@vigith
Copy link
Contributor

vigith commented Nov 19, 2022 •
edited
Loading

Today we are not testing the following two paths

  • Process function
  • replay code path during boot up

We can test these using PBQ backed by in-memory stores.
@vigith vigith mentioned this issue Nov 19, 2022
Closed
26 tasks
@vigith vigith added area/reduce Reduce operations like GroupByKey testing Testing and CI labels Nov 19, 2022
@vigith vigith changed the title Unit test for replay path using PBQ backed by in-memory store Unit test core code paths in reduce Nov 19, 2022
@yhl25 yhl25 mentioned this issue Nov 23, 2022
Merged
whynowy pushed a commit that referenced this issue Nov 29, 2022
@yhl25
fix: unit tests for replay. Closes #373 (#377)
2f94a91 
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
whynowy pushed a commit that referenced this issue Dec 7, 2022
@yhl25 @whynowy
fix: unit tests for replay. Closes #373 (#377)
13ce4d2 
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yhl25 yhl25

Labels
area/reduce Reduce operations like GroupByKey testing Testing and CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: unit tests for replay. Closes #373 yhl25/numaflow
2 participants
@vigith @yhl25