Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: join vertex UI support #1010

Merged
merged 3 commits into from
Sep 1, 2023
Merged

feat: join vertex UI support #1010

merged 3 commits into from
Sep 1, 2023

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Aug 31, 2023 •
edited
Loading

Fixes #936

  • Added support for back-edges
  • Added support for self-loop
  • Separated back-edges based on height for viewing
  • Supports appropriate graph rendering regardless of the order of edges in pipeline spec
  • Fixes consistent labels for multiple sources merging into a vertex
  • Modified the graph dimensions to prevent vertex overlapping edge label

TODO - update tests
image
image
image
image
image

@veds-g
join vertex UI support
8e407a8 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
veds-g and others added 2 commits August 31, 2023 21:15
@veds-g
Merge branch 'main' into join-UI
aa989a6
@veds-g
nits
fce2a14 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
@vigith
Copy link
Contributor

vigith commented Aug 31, 2023

awesome. can you ask Shakira to review please?

mshakira
mshakira approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@mshakira mshakira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice implementation

@vigith vigith merged commit 247b89e into numaproj:main Sep 1, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigith vigith vigith approved these changes

@mshakira mshakira mshakira approved these changes

@whynowy whynowy Awaiting requested review from whynowy whynowy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI support for Join Vertex
3 participants
@veds-g @vigith @mshakira