feat: implement pipeline validation for unsupported states #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whynowy
reviewed
Sep 14, 2023
pkg/reconciler/pipeline/validate.go
Outdated
| @@ -89,6 +89,17 @@ func ValidatePipeline(pl *dfv1.Pipeline) error { | |||
| return fmt.Errorf("pipeline has no sink, at least one vertex with 'sink' defined is required") | |||
| } | |||
|
|
|||
| for _, v := range pl.Spec.Vertices { | |||
There was a problem hiding this comment.
Shall we do something like below:
- Sources should have
to, but nofrom, - Sinks should have
from, but noto; - UDFs should have both.
And this can be done together with the for loop above.
There was a problem hiding this comment.
If this logic is in place, maybe we can remove the logic in line 165-170.
KeranYang
reviewed
Sep 14, 2023
pkg/reconciler/pipeline/validate.go
Outdated
| @@ -89,6 +89,17 @@ func ValidatePipeline(pl *dfv1.Pipeline) error { | |||
| return fmt.Errorf("pipeline has no sink, at least one vertex with 'sink' defined is required") | |||
| } | |||
|
|
|||
| for _, v := range pl.Spec.Vertices { | |||
KeranYang
reviewed
Sep 14, 2023
KeranYang
reviewed
Sep 14, 2023
KeranYang
approved these changes
Sep 14, 2023
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
…PendingNotAvailable (numaproj#1040) Signed-off-by: Keran Yang <yangkr920208@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
…ch (numaproj#1041) Signed-off-by: Derek Wang <whynowy@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: veds-g <guptavedant2312@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Derek Wang <whynowy@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Co-authored-by: Keran Yang <yangkr920208@gmail.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
dpadhiar
force-pushed
the
pipeline-validation
branch
from
ef81a48
to
5049c30
Compare
whynowy
approved these changes
Sep 14, 2023
whynowy
pushed a commit
that referenced
this pull request
Sep 15, 2023
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com> Signed-off-by: Keran Yang <yangkr920208@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially completes #1002
Adds pipeline validation to prevent pipelines to be submitted that have: