fix: daemon service rest api not working #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Derek Wang <whynowy@gmail.com>
whynowy
commented
Jul 21, 2022
| @@ -71,6 +71,6 @@ service DaemonService { | |||
| }; | |||
|
|
|||
| rpc GetVertexMetrics (GetVertexMetricsRequest) returns (GetVertexMetricsResponse) { | |||
| option (google.api.http).get = "/api/v1/namespace/{namespace}/pipelines/{pipeline}/vertices/{vertex}/metrics"; | |||
There was a problem hiding this comment.
We don't need namespace in the url, as the daemon service is namespaced, which already have the namespace in the host url.
vigith
approved these changes
Jul 21, 2022
whynowy
added a commit
that referenced
this pull request
Aug 6, 2022
* fix: daemon service rest api not working Signed-off-by: Derek Wang <whynowy@gmail.com> * test cases Signed-off-by: Derek Wang <whynowy@gmail.com> * . Signed-off-by: Derek Wang <whynowy@gmail.com> * fix Signed-off-by: Derek Wang <whynowy@gmail.com>
yhl25
pushed a commit
to yhl25/numaflow
that referenced
this pull request
Sep 1, 2022
* fix: daemon service rest api not working Signed-off-by: Derek Wang <whynowy@gmail.com> * test cases Signed-off-by: Derek Wang <whynowy@gmail.com> * . Signed-off-by: Derek Wang <whynowy@gmail.com> * fix Signed-off-by: Derek Wang <whynowy@gmail.com> Signed-off-by: Yashash H L <yashash_hl@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Wang whynowy@gmail.com
Daemon service should be accessible through either gRPC or REST.