feat: add processing rate to UI #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 21, 2022 11:55
Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com>
Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com>
Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com>
Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com>
|
|
vigith
changed the title
bbehnke
approved these changes
Jul 22, 2022
| const vertexToRateMap = new Map(); | ||
|
|
||
| if (pipeline?.spec?.vertices) { | ||
| Promise.all( |
There was a problem hiding this comment.
Not blocking, but may be beneficial to update server side to make one batched network call instead of many calls.
There was a problem hiding this comment.
That's a good point, I think I can tackle this in the next PR
Signed-off-by: Krithika Vijayakumar <krithika_vijayakumar@intuit.com>
vigith
approved these changes
Jul 22, 2022
whynowy
pushed a commit
that referenced
this pull request
Aug 6, 2022
Signed-off-by: Derek Wang <whynowy@gmail.com>
yhl25
pushed a commit
to yhl25/numaflow
that referenced
this pull request
Sep 1, 2022
Signed-off-by: Yashash H L <yashash_hl@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP: Add processing rates to UI