feat: health status implementation #1406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigith
reviewed
Dec 11, 2023
whynowy
reviewed
Dec 11, 2023
vigith
reviewed
Dec 13, 2023
vigith
reviewed
Dec 13, 2023
whynowy
reviewed
Dec 13, 2023
| func (hc *HealthChecker) StartHealthCheck(ctx context.Context) { | ||
| // Goroutine to listen for ticks | ||
| // At every tick, check and update the health status of the pipeline. | ||
| go func(ctx context.Context) { |
There was a problem hiding this comment.
Shouldn't the function StartHealthCheck be blocked? It's using a goroutine to start it in the daemon server.
There was a problem hiding this comment.
Updated. Please check if it seems fine now
yhl25
reviewed
Dec 14, 2023
vigith
approved these changes
Dec 16, 2023
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
|
@kohlisid - resolve the conflicts? |
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
Signed-off-by: Sidhant Kohli <sidhant.kohli@gmail.com>
whynowy
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Health status definitions
It is divided into two parts:
Resource Health can be "healthy (0) | unhealthy (1) | paused (3) | unknown (4)".
Resource Health purely means it is up and running.
Resource health will be the max(health) based of each vertex's health
Resource health checks if all the pods are in running state for the pipeline, and also for paused, unknown pipeline etc
Data Criticality on the other end shows whether the pipeline is working as expected.
It represents the pending messages, lags, etc.
Data Criticality can be "ok (0) | warning (1) | critical (2)".
A backlogged pipeline can be healthy even though it has an increasing back-pressure.
For data criticality the timeline data is populated for the pipeline, and if the average usage lies above the thresholds then the required state is assigned. For critical states we have the option do a lookback and only assign it to be critical if we see a predefined number of critical state in a lookback period window.