Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: server-secrets-init container restart #1433

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix: server-secrets-init container restart #1433

merged 1 commit into from
Jan 2, 2024

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Jan 2, 2024 •
edited

  • added env variable for namespace for accessing secrets and configMap for the server-secrets-init container
  • enabled access to UI by completing initialization for the server

yhl25
yhl25 approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@yhl25 yhl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix codegen

@veds-g
updated deployment config
13081c5 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
vigith
vigith approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this env var being used?

@veds-g
Copy link
Contributor Author

veds-g commented Jan 2, 2024 •
edited

How is this env var being used?

this var is the same namespace in which we will update k8s secret with data(JWT secretKey and initial admin password) for local user authn

@veds-g veds-g merged commit 58e215e into numaproj:main Jan 2, 2024
19 checks passed
whynowy pushed a commit that referenced this pull request Jan 2, 2024
@veds-g @whynowy
fix: server-secrets-init container restart (#1433)
af17d8c 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
(cherry picked from commit 58e215e)
akashjkhamkar pushed a commit to akashjkhamkar/numaflow that referenced this pull request Jan 2, 2024
@veds-g @akashjkhamkar
fix: server-secrets-init container restart (numaproj#1433)
7d4cf19 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
Signed-off-by: akashjkhamkar <akash.khamkar40@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigith vigith vigith approved these changes

@whynowy whynowy whynowy approved these changes

@yhl25 yhl25 yhl25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veds-g @vigith @whynowy @yhl25