Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pipeline health status for UI #1460

Merged
merged 4 commits into from
Jan 19, 2024
Merged

feat: pipeline health status for UI #1460

merged 4 commits into from
Jan 19, 2024

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Jan 16, 2024 •
edited

Fixes #1325

  • Updated health status for pipeline based on new health API
  • Calculated health based on consolidated value for Resource Health and Data Flow Health
  • Updated health status on both Namespace page and Pipeline page
  • Added tooltip to show detailed health information on hover
image

@veds-g
pipeline health status
86230c8 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
@whynowy
Copy link
Member

whynowy commented Jan 17, 2024

According to the screenshot:

  1. Do not capital first letter of every word of the tooltip.
  2. DataFlow -> Data Flow.
  3. Instead of using one large tooltip, can we do it separately when hover on the different icons?

veds-g and others added 2 commits January 18, 2024 17:22
@veds-g
review comments
6d883f4 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
@veds-g
Merge branch 'main' into pl-health-ui
7a2c99c
@whynowy whynowy merged commit 495d22b into numaproj:main Jan 19, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

@vigith vigith Awaiting requested review from vigith vigith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

reinvent health and status definitions for numaflow UI
2 participants
@veds-g @whynowy