fix(controller): incorrect cpu/mem resources calculation #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <whynowy@gmail.com>
vigith
approved these changes
Jan 23, 2024
whynowy
added a commit
that referenced
this pull request
Jan 23, 2024
Signed-off-by: Derek Wang <whynowy@gmail.com> (cherry picked from commit 0c53e8a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default
resourceis used as a reference to all the places that need to have a resource setting (for example, a vertex numa container), once there's a customization on the particular container resource, it updates all, which is wrong.Fix it by referencing to a new instance of the default resource.