-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure standardResources via controller configmap #1490
Conversation
12bcf65
to
b0c95db
Compare
closes numaproj#1487 Signed-off-by: Nishchith Shetty <inishchith@gmail.com>
b0c95db
to
22c51d4
Compare
Signed-off-by: Nishchith Shetty <inishchith@gmail.com>
9068d0d
to
79b7a9b
Compare
Is standardResources only for UDF containers? |
@vigith - Not just UDF. All init and main containers for vertex, daemon, redis_buffer_service. |
9bec019
to
ce6dda5
Compare
Signed-off-by: Nishchith Shetty <inishchith@gmail.com>
ce6dda5
to
86e4929
Compare
Signed-off-by: Nishchith Shetty <inishchith@gmail.com>
Signed-off-by: Nishchith Shetty <inishchith@gmail.com>
@inishchith - It looks good to me, can you please:
|
2421c43
to
cef94f9
Compare
@whynowy Thanks! I have updated the docs and config. |
cef94f9
to
a7e38a7
Compare
f97b00f
to
8ffff3a
Compare
Signed-off-by: Nishchith Shetty <inishchith@gmail.com>
4291b37
to
3a02190
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Signed-off-by: Nishchith Shetty <inishchith@gmail.com>
Better way to configure the memory and CPU resource requests
closes #1487
Sample configmap