-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid panic when ctx is canceled #1515
Conversation
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how was it working so far?
@@ -44,3 +44,8 @@ func (e ApplyUDFErr) IsInternalErr() bool { | |||
func (e ApplyUDFErr) Error() string { | |||
return fmt.Sprint(e.Message) | |||
} | |||
|
|||
// Is checks if the error is of the same type | |||
func (e ApplyUDFErr) Is(target error) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the function used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it hit the nerve in session
code :)
No description provided.