Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readonly view #1640

Merged
merged 3 commits into from
Apr 5, 2024
Merged

fix: readonly view #1640

merged 3 commits into from
Apr 5, 2024

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented Apr 4, 2024

  • Merged readonly flag with sysInfo API
  • Removed the /readonlyinfo endpoint
  • Read only defaults to false, edit shared config variable server.readonly to enable it

Signed-off-by: veds-g <guptavedant2312@gmail.com>
@veds-g veds-g marked this pull request as ready for review April 4, 2024 09:35
@whynowy
Copy link
Member

whynowy commented Apr 4, 2024

@veds-g - Thanks!

  1. Comment this line since by default it's false.
  2. When it's readonly, all the Create/Update/Delete APIs should return 403 forbidden.

@vigith
Copy link
Contributor

vigith commented Apr 4, 2024

  1. When it's readonly, all the Create/Update/Delete APIs should return 403 forbidden.

very valid point :)

Signed-off-by: veds-g <guptavedant2312@gmail.com>
Signed-off-by: veds-g <guptavedant2312@gmail.com>
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whynowy whynowy merged commit a629703 into numaproj:main Apr 5, 2024
23 checks passed
yhl25 pushed a commit that referenced this pull request Apr 9, 2024
Signed-off-by: veds-g <guptavedant2312@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants