Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable Rust Unit Tests And Code Coverage in CI #1767

Merged
merged 14 commits into from
Jun 24, 2024
Merged

chore: Enable Rust Unit Tests And Code Coverage in CI #1767

merged 14 commits into from
Jun 24, 2024

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Jun 24, 2024

No description provided.

Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (07483c8) to head (6653320).

Files Patch % Lines
pkg/udf/rpc/grpc_aligned_reduce.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1767      +/-   ##
==========================================
+ Coverage   56.91%   61.02%   +4.11%     
==========================================
  Files         218      232      +14     
  Lines       17581    20014    +2433     
==========================================
+ Hits        10006    12214    +2208     
- Misses       6724     6944     +220     
- Partials      851      856       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
@yhl25 yhl25 marked this pull request as ready for review June 24, 2024 13:44
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
@yhl25 yhl25 changed the title chore: Enable Rust Unit Tests in CI chore: Enable Rust Unit Tests And Code Coverage in CI Jun 24, 2024
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Copy link
Member

@vigith vigith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with renaming Unit Tests to Unit Tests Go because we should add NodeJS in the future.

@vigith vigith merged commit c70540b into main Jun 24, 2024
26 checks passed
@vigith vigith deleted the ci branch June 24, 2024 20:59
samhith-kakarla pushed a commit to samhith-kakarla/numaflow that referenced this pull request Jul 5, 2024
Signed-off-by: Yashash H L <yashashhl25@gmail.com>
Signed-off-by: Samhith Kakarla <samhith_kakarla@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants