Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pipeline view fix #755

Merged
merged 5 commits into from
May 30, 2023
Merged

fix: pipeline view fix #755

merged 5 commits into from
May 30, 2023

Conversation

veds-g
Copy link
Contributor

@veds-g veds-g commented May 27, 2023 •
edited
Loading

Fixes #739

  • Moved BufferInfo from Edge to Vertex
  • Renamed Edge Label, and it contains Watermark and Conditions
  • Used Partitions instead of Parallelism to query for pod level metrics for a vertex
  • Updated the watermark fetcher map to contain fetcher for each pod of a vertex

image
image

@veds-g
pipeline view fix
bbea4c8 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
@veds-g
fixing metrics query test
63a5c15 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
@veds-g
updating watermark fetcher map to contain fetchers per partition
1cfaac5 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
@veds-g
Merge branch 'main' into pipeline-view-fix
32dfe0a 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
@veds-g veds-g marked this pull request as ready for review May 30, 2023 05:52
@veds-g
nits
0126993 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
whynowy
whynowy approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@whynowy whynowy enabled auto-merge (squash) May 30, 2023 06:37
@whynowy whynowy merged commit f327317 into numaproj:main May 30, 2023
14 checks passed
whynowy pushed a commit that referenced this pull request May 30, 2023
@veds-g @whynowy
fix: pipeline view fix (#755)
67277b7 
Signed-off-by: veds-g <guptavedant2312@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

@vigith vigith Awaiting requested review from vigith vigith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pipeline view is broken
2 participants
@veds-g @whynowy