refactor: build wmstore and wmstorewatcher directly, and remove some unnecessary fields #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Derek Wang <whynowy@gmail.com>
Signed-off-by: Derek Wang <whynowy@gmail.com>
whynowy
commented
Aug 20, 2023
| bucketName: bucketName, | ||
| kvEntryCh: kvEntryCh, | ||
| kvHistory: []kvs.KVEntry{}, | ||
| updatesChMap: make(map[string]chan kvs.KVEntry), | ||
| doneCh: make(chan struct{}), | ||
| log: logging.FromContext(ctx).With("pipeline", pipelineName).With("bucketName", bucketName), | ||
| log: logging.FromContext(ctx).With("bucketName", bucketName), |
There was a problem hiding this comment.
Only for logging, removed.
| var err error | ||
| var jsStore = &jetStreamStore{ | ||
| client: client, | ||
| log: logging.FromContext(ctx).With("pipeline", pipelineName).With("kvName", kvName), | ||
| log: logging.FromContext(ctx).With("kvName", kvName), |
There was a problem hiding this comment.
The log in ctx comes with pipeline.
| @@ -66,7 +66,7 @@ func NewKVJetStreamKVWatch(ctx context.Context, pipelineName string, kvName stri | |||
| kvwTimer: time.NewTimer(kvOpts.watcherCreationThreshold), | |||
| opts: kvOpts, | |||
| doneCh: make(chan struct{}), | |||
| log: logging.FromContext(ctx).With("pipeline", pipelineName).With("kvName", kvName), | |||
| log: logging.FromContext(ctx).With("kvName", kvName), | |||
There was a problem hiding this comment.
The log in ctx comes with pipeline.
| fromBufferPartitionCount: fromBufferPartitionCount, | ||
| log: logging.FromContext(ctx).With("bucket", bucket), | ||
| log: logging.FromContext(ctx), |
There was a problem hiding this comment.
The log from the ctx comes with bucket.
| // Initialize a new empty watermarks DLL with nil values of the size capacity. | ||
| // This is to avoid length check: when a new element is added, the tail element will be deleted. | ||
| offsetTimeline := OffsetTimeline{ | ||
| ctx: ctx, | ||
| capacity: c, | ||
| log: logging.FromContext(ctx).With("bucket", bucket), | ||
| log: logging.FromContext(ctx), |
There was a problem hiding this comment.
The log already has bucket.
whynowy
changed the title
vigith
approved these changes
Aug 21, 2023
yhl25
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WatermarkStoreandWatermarkStoreWatcherdirectly frombucket.bucket(only for logging) as an arg, usectxto pass it.pipeline(only for logging) as an arg, usectxto pass it.