Skip to content

Commit

Permalink
moved RDS Config to AWS Utils
Browse files Browse the repository at this point in the history
feat: Adding utilities to connect AWS services like RDS

adding AWS Dataservices connectors utilities

----
Signed-off-by: Saisharath <srsharathreddy@gmail.com>
Signed-off-by: skondakindi <saisharathreddy_kondakindi@intuit.com>
  • Loading branch information
skondakindi committed Apr 9, 2024
1 parent 8560a07 commit 49e5bab
Show file tree
Hide file tree
Showing 10 changed files with 11 additions and 8 deletions.
3 changes: 3 additions & 0 deletions numalogic/connectors/rds/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
from numalogic.connectors.rds._rds import RDSFetcher

__all__ = ["RDSFetcher"]
2 changes: 1 addition & 1 deletion numalogic/connectors/rds/_base.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from typing import Optional
import pandas as pd
from numalogic.connectors.rds._config import DatabaseServiceProvider, RDSConfig
from numalogic.connectors.utils.aws.config import DatabaseServiceProvider, RDSConfig
from numalogic.connectors.utils.aws.boto3_client_manager import Boto3ClientManager
import logging
from numalogic.connectors._config import Pivot
Expand Down
2 changes: 1 addition & 1 deletion numalogic/connectors/rds/_rds.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from typing import Optional
from numalogic.connectors._base import DataFetcher
from numalogic.connectors._config import Pivot
from numalogic.connectors.rds._config import RDSConfig
from numalogic.connectors.utils.aws.config import RDSConfig
import logging
import pandas as pd
from numalogic.connectors.rds.db.factory import RdsFactory
Expand Down
2 changes: 1 addition & 1 deletion numalogic/connectors/rds/db/mysql_fetcher.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import pandas as pd
import logging

from numalogic.connectors.rds._config import DatabaseTypes, RDSConfig
from numalogic.connectors.utils.aws.config import DatabaseTypes, RDSConfig

_LOGGER = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion numalogic/connectors/utils/aws/boto3_client_manager.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from boto3 import Session
import logging

from numalogic.connectors.rds._config import DatabaseServiceProvider
from numalogic.connectors.utils.aws.config import DatabaseServiceProvider
from numalogic.connectors.utils.aws.exceptions import UnRecognizedAWSClientException
from numalogic.connectors.utils.aws.sts_client_manager import STSClientManager

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion numalogic/connectors/utils/aws/db_configurations.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from numalogic.tools.exceptions import ConfigNotFoundError
from omegaconf import OmegaConf
from numalogic.connectors.rds._config import RDSConfig
from numalogic.connectors.utils.aws.config import RDSConfig

_LOGGER = logging.getLogger(__name__)

Expand Down
2 changes: 1 addition & 1 deletion tests/connectors/rds/db/test_mysql_fetcher.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from unittest.mock import patch, Mock, MagicMock

from numalogic.connectors.rds._config import RDSConfig
from numalogic.connectors.utils.aws.config import RDSConfig
from numalogic.connectors.rds.db.mysql_fetcher import MysqlFetcher


Expand Down
2 changes: 1 addition & 1 deletion tests/connectors/rds/test_rds.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import pytest
from pandas import DataFrame

from numalogic.connectors.rds._config import RDSConfig
from numalogic.connectors.utils.aws.config import RDSConfig
from numalogic.connectors.rds._rds import RDSFetcher
import pandas as pd

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from numalogic.connectors.rds._config import (
from numalogic.connectors.utils.aws.config import (
DatabaseTypes,
AWSConfig,
SSLConfig,
Expand Down

0 comments on commit 49e5bab

Please sign in to comment.