Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: consistency with threshold methods #138

Merged
merged 2 commits into from
Feb 9, 2023
Merged

fix!: consistency with threshold methods #138

merged 2 commits into from
Feb 9, 2023

Conversation

ab93
Copy link
Member

@ab93 ab93 commented Feb 8, 2023

Signed-off-by: Avik Basu ab93@users.noreply.github.com

Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 self-assigned this Feb 8, 2023
Signed-off-by: Avik Basu <ab93@users.noreply.github.com>
@ab93 ab93 changed the title fix: consistency with threshold methods fix!: consistency with threshold methods Feb 8, 2023
@ab93 ab93 added documentation Improvements or additions to documentation area/ml Machine Learning based changes labels Feb 8, 2023
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #138 (87ad4d2) into main (2ac1c2f) will increase coverage by 0.29%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   97.07%   97.36%   +0.29%     
==========================================
  Files          33       33              
  Lines        1059     1063       +4     
  Branches       75       75              
==========================================
+ Hits         1028     1035       +7     
+ Misses         22       20       -2     
+ Partials        9        8       -1     
Impacted Files Coverage Δ
numalogic/models/threshold/_static.py 100.00% <100.00%> (ø)
numalogic/models/threshold/_std.py 94.11% <100.00%> (+0.78%) ⬆️
numalogic/synthetic/anomalies.py 96.84% <0.00%> (+3.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ab93 ab93 marked this pull request as ready for review February 8, 2023 23:45
@ab93 ab93 requested a review from s0nicboOm February 9, 2023 00:28
@ab93 ab93 merged commit 4eae629 into main Feb 9, 2023
@ab93 ab93 deleted the small-fixes branch February 9, 2023 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ml Machine Learning based changes documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants