Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redis logging #209

Merged
merged 3 commits into from
Jun 6, 2023
Merged

fix: redis logging #209

merged 3 commits into from
Jun 6, 2023

Conversation

s0nicboOm
Copy link
Contributor

Explain what this PR does.

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #209 (0b5f2d0) into main (b93bce5) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   96.36%   96.55%   +0.18%     
==========================================
  Files          40       40              
  Lines        1596     1596              
  Branches      125      125              
==========================================
+ Hits         1538     1541       +3     
+ Misses         44       42       -2     
+ Partials       14       13       -1     
Impacted Files Coverage Δ
numalogic/registry/redis_registry.py 97.63% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@s0nicboOm s0nicboOm marked this pull request as ready for review June 6, 2023 19:47
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
@s0nicboOm s0nicboOm merged commit 4058811 into numaproj:main Jun 6, 2023
9 checks passed
@s0nicboOm s0nicboOm deleted the redis-log branch June 6, 2023 20:27
ab93 pushed a commit that referenced this pull request Jun 6, 2023
Explain what this PR does.

---------

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
ab93 pushed a commit that referenced this pull request Jun 6, 2023
Explain what this PR does.

---------

Signed-off-by: s0nicboOm <i.kushalbatra@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants